commit 423d6a6156cea32757f13277e31a5867aec12dca (HEAD, refs/remotes/origin/master) Author: Paul Eggert Date: Fri Apr 1 01:24:55 2016 -0700 Fix check for subscript errors in module calls * src/emacs-module.c (check_vec_index): New function. (module_vec_set, module_vec_get): Use it instead of a not-strict-enough check. diff --git a/src/emacs-module.c b/src/emacs-module.c index f9ede84..b57636e 100644 --- a/src/emacs-module.c +++ b/src/emacs-module.c @@ -588,13 +588,21 @@ module_set_user_finalizer (emacs_env *env, emacs_value uptr, } static void +check_vec_index (Lisp_Object lvec, ptrdiff_t i) +{ + CHECK_VECTOR (lvec); + if (! (0 <= i && i < ASIZE (lvec))) + args_out_of_range_3 (make_fixnum_or_float (i), + make_number (0), make_number (ASIZE (lvec) - 1)); +} + +static void module_vec_set (emacs_env *env, emacs_value vec, ptrdiff_t i, emacs_value val) { /* FIXME: This function should return bool because it can fail. */ MODULE_FUNCTION_BEGIN (); Lisp_Object lvec = value_to_lisp (vec); - CHECK_VECTOR (lvec); - CHECK_RANGED_INTEGER (make_number (i), 0, ASIZE (lvec) - 1); + check_vec_index (lvec, i); ASET (lvec, i, value_to_lisp (val)); } @@ -603,8 +611,7 @@ module_vec_get (emacs_env *env, emacs_value vec, ptrdiff_t i) { MODULE_FUNCTION_BEGIN (module_nil); Lisp_Object lvec = value_to_lisp (vec); - CHECK_VECTOR (lvec); - CHECK_RANGED_INTEGER (make_number (i), 0, ASIZE (lvec) - 1); + check_vec_index (lvec, i); return lisp_to_value (AREF (lvec, i)); } commit 750e1e19429cd781e2e60b462d19ef827d4da943 Author: Simen Heggestøyl Date: Thu Mar 31 21:18:00 2016 +0200 Support completion of bang-rules in CSS mode lisp/textmodes/css-mode.el (css--bang-ids): New buffer-local variable holding the list of bang-rules for the current mode. (css--font-lock-keywords): Retrieve bang-rules from `css--bang-ids' instead of computing them. (css--complete-bang-rule): New function for completing a bang-rule. (css-completion-at-point): Add support for completing bang-rules. (scss-font-lock-keywords): Change from a variable to a function in order to recompute `css--font-lock-keywords' when `css--bang-ids' has changed. (scss-mode): Set `css--bang-ids' and recompute font-lock keywords. diff --git a/etc/NEWS b/etc/NEWS index 66777e9..726b4b9 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -144,8 +144,8 @@ different group ID. ** CSS mode --- -*** Support for completing attribute values using the 'completion-at-point' -command. +*** Support for completing attribute values and bang-rules using the +'completion-at-point' command. * New Modes and Packages in Emacs 25.2 diff --git a/lisp/textmodes/css-mode.el b/lisp/textmodes/css-mode.el index fd3459e..cbef3d4 100644 --- a/lisp/textmodes/css-mode.el +++ b/lisp/textmodes/css-mode.el @@ -64,6 +64,10 @@ '("default" "global" "optional") "Additional identifiers that appear in the form !foo in SCSS.") +(defvar css--bang-ids css-bang-ids + "List of bang-rules for the current mode.") +(make-variable-buffer-local 'css--bang-ids) + (defconst css-descriptor-ids '("ascent" "baseline" "bbox" "cap-height" "centerline" "definition-src" "descent" "font-family" "font-size" "font-stretch" "font-style" @@ -600,9 +604,7 @@ cannot be completed sensibly: `angle', `element-reference', "Face to use for vendor-specific properties.") (defun css--font-lock-keywords (&optional sassy) - `((,(concat "!\\s-*" - (regexp-opt (append (if sassy scss-bang-ids) - css-bang-ids))) + `((,(concat "!\\s-*" (regexp-opt css--bang-ids)) (0 font-lock-builtin-face)) ;; Atrules keywords. IDs not in css-at-ids are valid (ignored). ;; In fact the regexp should probably be @@ -732,6 +734,14 @@ cannot be completed sensibly: `angle', `element-reference', (when (memq (char-before) '(?\{ ?\;)) (list start pos css-property-ids)))))) +(defun css--complete-bang-rule () + "Complete bang-rule at point." + (save-excursion + (let ((pos (point))) + (skip-chars-backward "-[:alnum:]") + (when (eq (char-before) ?\!) + (list (point) pos css--bang-ids))))) + (defun css--complete-pseudo-element-or-class () "Complete pseudo-element or pseudo-class at point." (save-excursion @@ -798,8 +808,9 @@ the string PROPERTY." (defun css-completion-at-point () "Complete current symbol at point. Currently supports completion of CSS properties, property values, -pseudo-elements, pseudo-classes, and at-rules." +pseudo-elements, pseudo-classes, at-rules, and bang-rules." (or (css--complete-property) + (css--complete-bang-rule) (css--complete-property-value) (css--complete-pseudo-element-or-class) (css--complete-at-rule))) @@ -937,7 +948,7 @@ pseudo-elements, pseudo-classes, and at-rules." (modify-syntax-entry ?$ "'" st) st)) -(defvar scss-font-lock-keywords +(defun scss-font-lock-keywords () (append `((,(concat "$" css-ident-re) (0 font-lock-variable-name-face))) (css--font-lock-keywords 'sassy) `((,(concat "@mixin[ \t]+\\(" css-ident-re "\\)[ \t]*(") @@ -958,7 +969,9 @@ pseudo-elements, pseudo-classes, and at-rules." (setq-local comment-continue " *") (setq-local comment-start-skip "/[*/]+[ \t]*") (setq-local comment-end-skip "[ \t]*\\(?:\n\\|\\*+/\\)") - (setq-local font-lock-defaults '(scss-font-lock-keywords nil t))) + (setq-local css--bang-ids (append css-bang-ids scss-bang-ids)) + (setq-local font-lock-defaults + (list (scss-font-lock-keywords) nil t))) (provide 'css-mode) ;;; css-mode.el ends here